Skip to content
This repository was archived by the owner on Jun 26, 2026. It is now read-only.

Preventing script injection attacks#55

Closed
jheckey wants to merge 1 commit into
amazon-braket:mainfrom
jheckey:no_injection
Closed

Preventing script injection attacks#55
jheckey wants to merge 1 commit into
amazon-braket:mainfrom
jheckey:no_injection

Conversation

@jheckey

@jheckey jheckey commented Sep 26, 2025

Copy link
Copy Markdown

Issue #, if available:

Description of changes:

Ref: https://docs.github.com/en/actions/reference/security/secure-use#good-practices-for-mitigating-script-injection-attacks

  • Replaced github variables with temporary variables
  • Put URL in quotes for env var substitutions

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Ref: https://docs.github.com/en/actions/reference/security/secure-use#good-practices-for-mitigating-script-injection-attacks

* Replaced github variables with temporary variables
* Put URL in quotes for env var substitutions
@jheckey jheckey requested a review from a team as a code owner September 26, 2025 22:10
@virajvchaudhari

Copy link
Copy Markdown
Contributor

Same as default-sim repo: #53

@codecov

codecov Bot commented Sep 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e77b5dd). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage        ?   61.41%           
=======================================
  Files           ?        6           
  Lines           ?      184           
  Branches        ?       26           
=======================================
  Hits            ?      113           
  Misses          ?       63           
  Partials        ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jheckey

jheckey commented Sep 26, 2025

Copy link
Copy Markdown
Author

Ack, thank you.

@jheckey jheckey closed this Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants